Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Metal backend #175

Merged
merged 49 commits into from
Oct 30, 2024
Merged

Add support for Metal backend #175

merged 49 commits into from
Oct 30, 2024

Conversation

GiackAloZ
Copy link
Contributor

@GiackAloZ GiackAloZ commented Oct 23, 2024

This PR adds support for the Metal backend, which makes it possible to use Apple silicon GPUs.

Supported features:

  • up to single precision Float32 floating points (Float64 is NOT supported by Metal)
  • all Apple Silicon GPUs supported by Metal v1.2 and higher

TODO:

  • add support for memopt flag for Metal backend (currently not working)

@omlins omlins self-requested a review October 23, 2024 15:43
Copy link
Owner

@omlins omlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I have almost only a small suggestions that you can insert directly by accepting them.
For the unit tests, it would be nice if one could keep the tests checking for bitwise identical results

Project.toml Outdated Show resolved Hide resolved
src/ParallelKernel/parallel.jl Outdated Show resolved Hide resolved
src/ParallelKernel/parallel.jl Outdated Show resolved Hide resolved
src/ParallelKernel/parallel.jl Outdated Show resolved Hide resolved
src/ParallelStencil.jl Outdated Show resolved Hide resolved
test/test_parallel.jl Outdated Show resolved Hide resolved
test/test_parallel.jl Outdated Show resolved Hide resolved
test/test_parallel.jl Outdated Show resolved Hide resolved
test/test_parallel.jl Outdated Show resolved Hide resolved
test/test_parallel.jl Outdated Show resolved Hide resolved
test/test_FiniteDifferences1D.jl Outdated Show resolved Hide resolved
test/test_FiniteDifferences2D.jl Outdated Show resolved Hide resolved
test/test_FiniteDifferences3D.jl Outdated Show resolved Hide resolved
GiackAloZ and others added 2 commits October 30, 2024 15:03
@omlins omlins merged commit 0390670 into omlins:main Oct 30, 2024
4 checks passed
@omlins
Copy link
Owner

omlins commented Oct 30, 2024

Thanks @GiackAloZ , @albert-de-montserrat !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants