-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Metal
backend
#175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omlins
requested changes
Oct 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! I have almost only a small suggestions that you can insert directly by accepting them.
For the unit tests, it would be nice if one could keep the tests checking for bitwise identical results
Co-authored-by: Samuel Omlin <[email protected]> Co-authored-by: Albert de Montserrat <[email protected]>
Co-authored-by: Samuel Omlin <[email protected]>
Co-authored-by: Samuel Omlin <[email protected]>
… in the diffusion3D_step! function
Co-authored-by: Samuel Omlin <[email protected]>
… latter is deprecated) Also add tests there were TODO
omlins
approved these changes
Oct 30, 2024
Thanks @GiackAloZ , @albert-de-montserrat ! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
Metal
backend, which makes it possible to use Apple silicon GPUs.Supported features:
Float32
floating points (Float64
is NOT supported byMetal
)Metal
v1.2 and higherTODO:
memopt
flag for Metal backend (currently not working)